[patch-v2.6.39 5/7] AM35xx: hwmod data: Add USBOTG

[Premi, Sanjeev]

> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> owner at vger.kernel.org] On Behalf Of Balbi, Felipe
> Sent: Thursday, February 17, 2011 6:11 PM
> To: Tony Lindgren
> Cc: Linux OMAP Mailing List; Linux ARM Kernel Mailing List; Kalliguddi,
> Hema; Kevin Hilman; Cousson, Benoit; Paul Walmsley; Balbi, Felipe
> Subject: [patch-v2.6.39 5/7] AM35xx: hwmod data: Add USBOTG
> 
> From: Hema HK <hemahk at ti.com>
> 
> AM35xx hwmod data structures are populated for USBOTG with base address,
> L3 and L4 interface clocks and IRQ.
> 
> Signed-off-by: Hema HK <hemahk at ti.com>
> Cc: Tony Lindgren <tony at atomide.com>
> Cc: Kevin Hilman <khilman at deeprootsystems.com>
> Cc: Cousson, Benoit <b-cousson at ti.com>
> Cc: Paul Walmsley <paul at pwsan.com>
> Signed-off-by: Felipe Balbi <balbi at ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   65
> ++++++++++++++++++++++++++++
>  1 files changed, 65 insertions(+), 0 deletions(-)
> 
[snip]
> 
> +	/* usbotg for am35x */
> +	&am35xx_usbhsotg_hwmod,
> +
>  	NULL,

Felipe, Hema,

This patch will break all existing OMAP35x (and I believe
OMAP3430 - since there is no difference - unless there is
some trick in the USB driver code).

I have seen similar problems with smart reflex included in
the AM35x hwmod data.

In this case accessing "unknown" registers corresponding to
SmartReflex in _setup() causes crash.
(http://marc.info/?l=linux-omap&m=129777408503329&w=2)

I expect similar to be happening on OMAP35x with inclusion
of am35xx_usbhsotg_hwmod. If you don't see any crash, there
would be side-effects - and _setup() would be initializing
non-existent OTG registers on OMAP35x.

Did you see any problems while testing?

~sanjeev

PS: Sending mail via webmailer. Formatting may break

>  };
> 
> --
> 1.7.4.rc2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html