[PATCH 0/4] ARM: add support for hw-breakpoints [v4]

[Ulrich Weigand]

"Will Deacon" <will.deacon at arm.com> wrote on 02/16/2011 12:59:49 PM:

> > There seems to be a bug in the gdb patch... There should probably
> be a separate loop for wpts.
> >
> >       for (i = 0; i < info->bp_count; i++)
> > >    {
> > >      if (arm_hwbp_control_is_enabled (p->bpts[i].control))
> > >        arm_linux_insert_hw_breakpoint1 (p->bpts + i, tid, 0);
> > >      if (arm_hwbp_control_is_enabled (p->wpts[i].control))
> > >        arm_linux_insert_hw_breakpoint1 (p->wpts + i, tid, 1);
> > >    }
>
> Ulrich Weigand (added to CC) is dealing with the GDB patches, so he
> will have more idea about this than me. Last I heard, the testsuite
> was passing so I guess this has been fixed if it was a problem.

Yes, this is indeed a bug (it only occurs sporadically, since its
effect is to access random memory), and it should be fixed by
using two separate loops.

That's one of the changes I've had to make as well.  I'll post an
updated patch set including all the changes required to get a clean
testsuite run shortly ...



Mit freundlichen Gruessen / Best Regards

Ulrich Weigand

--
  Dr. Ulrich Weigand | Phone: +49-7031/16-3727
  STSM, GNU compiler and toolchain for Linux on System z and Cell/B.E.
  IBM Deutschland Research & Development GmbH
  Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: Dirk
Wittkopp
  Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht
Stuttgart, HRB 243294