[PATCH V4] OMAP3: PM: Set/clear T2 bit for Smartreflex on TWL
Gulati, Shweta
shweta.gulati at ti.com
Wed Feb 16 00:52:09 EST 2011
On Tue, Feb 15, 2011 at 8:59 PM, Jarkko Nikula <jhnikula at gmail.com> wrote:
> On Tue, 15 Feb 2011 17:16:52 +0200
> Jarkko Nikula <jhnikula at gmail.com> wrote:
>
>> Would it make more sense to set only the flag here and do the register
>> writes when omap3_twl_init is executing? Then it's not so strict when
>> the board code calls this function.
>>
> Probably discussed earlier but would it make more sense to have flag in
> struct twl4030_platform_data and to do registers writes in twl-core?
> Looks suspicious to have i2c_writes under arch/arm/.
twl_i2c_read/write APIs are used from arch/arm in many board files,
so I think it should not cause any issue.
> --
> Jarkko
>
--
Thanks,
Regards,
Shweta
More information about the linux-arm-kernel
mailing list