[PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

[Ramirez Luna, Omar]

Hi,

On Tue, Feb 15, 2011 at 4:05 PM, Cousson, Benoit <b-cousson at ti.com> wrote:
>> It is this way instead of plain platform_get_irq because omap2420 has
>> two interrupt sources to MPU and mailbox driver uses
>> platform_get_irq_byname to get the irq number.
>
> This is what I was thinking, except that on OMAP2420 the names are:
> +       { .name = "dsp", .irq = 26, },
> +       { .name = "iva", .irq = 34, },
>
> and on OMAP2430 and OMAP3
> +       { .name = "dsp", .irq = 26, },
>
> so why is it named "mbox" on OMAP4?

I'm not very familiar with OMAP4 terminology... but IMHO, I guess
naming it dsp, would imply that this is a mailbox for the dsp, when
the interrupt can be generated by either the M3, dsp, I think even the
IVA can write into it.

> If you have to do several platform_get_irq_byname to get this one, I'd
> prefer to get rid of that name for OMAP4. It will make mailbox irq
> consistent with the other hwmods.

I was thinking to standardize the names to be mbox0..mboxN across all
the platforms, reason being that the mailbox also has capabilities to
be used not only by dsp or iva, by using a polling method.

So even if the mailbox in OMAP3 is called "dsp", it has 4 more queues
apart from the 2 used for messaging between arm and dsp, that could be
used even if tidspbridge wasn't there.

Did I get you correctly?

Regards,

Omar