[PATCH v5 3/5] OMAP4: hwmod data: add mailbox data
Ramirez Luna, Omar
omar.ramirez at ti.com
Tue Feb 15 16:55:41 EST 2011
Hi Benoit,
On Mon, Feb 14, 2011 at 9:00 AM, Cousson, Benoit <b-cousson at ti.com> wrote:
>> +static struct omap_hwmod_irq_info omap44xx_mailbox_irqs[] = {
>> + { .name = "mbox", .irq = 26 + OMAP44XX_IRQ_GIC_START, },
>
> The original entry was unnamed since it is an unique entry and thus does not
> need to be differentiate on this platform.
>
> { .irq = 26 + OMAP44XX_IRQ_GIC_START },
>
> Do you really need to have a name here? The strategy being to provide a name
> only if more than one entry exist.
> It is perfectibility doable, I'm just trying to understand your rational.
It is this way instead of plain platform_get_irq because omap2420 has
two interrupt sources to MPU and mailbox driver uses
platform_get_irq_byname to get the irq number.
Regards,
Omar
More information about the linux-arm-kernel
mailing list