[PATCH 1/2] OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg()

Jarkko Nikula jhnikula at gmail.com
Tue Feb 15 08:59:48 EST 2011


On Tue, 15 Feb 2011 15:44:27 +0200
David Cohen <dacohen at gmail.com> wrote:

> >> @@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj,
> >> u32 *ra)
> >>        da = iommu_read_reg(obj, MMU_FAULT_AD);
> >>        *ra = da;
> >>
> >> -       dev_err(obj->dev, "%s:\tda:%08x ", __func__, da);
> >> +       dev_dbg(obj->dev, "%s:\tda:%08x ", __func__, da);
> >
> >   Note that dev_dbg() will only print something if either DEBUG or
> > CONFIG_DYNAMIC_DEBUG are defined...
> 
> That's my plan.
> 
So it's sure that a developer won't need these error dumps when
receiving an error report? I.e. IOMMU upper level errors give enough
information to start doing own debugging?

Just my 2 cents.

-- 
Jarkko



More information about the linux-arm-kernel mailing list