[RFC,PATCH 2/3] clk: Generic support for fixed-rate clocks
Jeremy Kerr
jeremy.kerr at canonical.com
Mon Feb 14 20:41:00 EST 2011
Hi Ryan,
> A fixed clock may still have other operations such as enable/disable.
Then it's not a fixed clock; I'd prefer this to be a separate type, as it's
now hardware dependent.
> Maybe do something like this instead:
> #define INIT_CLK_FIXED(name, ops, r) { \
> .clk = INIT_CLK(name.clk, ops, rate), \
> .clk.ops.get_rate = clk_fixed_get_rate, \
> .rate = (r), \
> }
>
> That's untested though. I'm not sure if you can reliably assign
> something twice in a struct initialiser?
also, clk->ops is a const.
Cheers,
Jeremy
More information about the linux-arm-kernel
mailing list