[PATCH RESEND v6 2/4] TI816X: Update common OMAP machine specific sources
Pedanekar, Hemant
hemantp at ti.com
Mon Feb 14 20:09:27 EST 2011
Hilman, Kevin wrote on Tuesday, February 15, 2011 4:58 AM:
> Hemant Pedanekar <hemantp at ti.com> writes:
>
> [...]
>
>> @@ -402,7 +422,7 @@ void __init
> omap2_init_common_devices(struct omap_sdrc_params *sdrc_cs0,
>>
>> omap_hwmod_late_init();
>>
>> - if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
>> + if (omap3_has_sdrc()) {
>> omap2_sdrc_init(sdrc_cs0, sdrc_cs1);
>> _omap2_init_reprogram_sdrc();
>> }
>
> At first glance, this one doesn't look quite right. Will
> omap3_has_sdrc() be true on 24xx? Please confirm.
>
> Kevin
You are right, this is incorrect as there is no 'features' set for
omap24xx. I will send new version with cpu_is_omap24xx() check retained.
Thanks.
Hemant
More information about the linux-arm-kernel
mailing list