[PATCH 5/5] arm: mach-mmp: brownstone.c support multiple sd slots

Arnd Bergmann arnd at arndb.de
Mon Feb 14 09:10:47 EST 2011


On Monday 14 February 2011, Philip Rakity wrote:
> +
> +       gpio_direction_output(poweron, 1);
> +       mdelay (20);
> +       gpio_direction_output(reset, 0);
> +       mdelay (20);
> +       gpio_direction_output(reset, 1);
> +       gpio_free(reset);
> +       gpio_free(poweron);

mdelay is not nice, especially in boot code, because a lot of people
are interested in reducing boot times, and 40 miliseconds is definitely
in the range that people notice.

At the very least, change it from mdelay() to msleep(), to allow other
processes to continue.

Ideally, you can run the function in the background using schedule_work(),
but there may be better ways to do that for the entire platform code.

	Arnd



More information about the linux-arm-kernel mailing list