[PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

Paul Walmsley paul at pwsan.com
Fri Feb 11 00:14:21 EST 2011


Hi Rajendra

On Fri, 11 Feb 2011, Rajendra Nayak wrote:

> Failing silently is going to make it more difficult to identify and fix. 
> Maybe a WARN in else?
> 
> 	if (cd->clkdm) {
> 		...
> 	} else
> 		WARN()

I was thinking it might be nice to put it right next to the 
_clkdm_lookup()s in clkdm_init(), since the _clkdm_lookup is what is 
actually failing.  Then we could do a

if (!cd->clkdm)
	continue;

in the SoC-specific *_all_wkdep/sleepdep* code, just to keep the system 
from crashing...

Does that sound okay to you?


- Paul



More information about the linux-arm-kernel mailing list