[PATCH 1/2] video: Add i.MX23/28 framebuffer driver

Li Frank-B20596 B20596 at freescale.com
Wed Feb 9 22:16:16 EST 2011


> +#define CTRL				0x00
> +#define CTRL1				0x10
> +#define MX28_CTRL2			0x20
> +#define MX23_TRANSFER_COUNT		0x20
> +#define MX28_TRANSFER_COUNT		0x30
> +#define MX28_CUR_BUF			0x40
> +#define MX28_NEXT_BUF			0x50
> +#define MX23_CUR_BUF			0x30
> +#define MX23_NEXT_BUF			0x40
> +#define TIMING				0x60
> +#define VDCTRL0				0x70
> +#define VDCTRL1				0x80
> +#define VDCTRL2				0x90
> +#define VDCTRL3				0xa0
> +#define VDCTRL4				0xb0

Why you give up mx23/mx28 register define role, which generate from SOC xml. 
There is a set header files for each mx23/mx28 module, which generate from xml.  
I know original header files affect run time one Image. 
But I think we can copy common part of such register definition because
That keep consistent with mx23/mx28 data sheet. Data sheet and header file generate
from one source xml.

HW_<Module name>_<Register name>.
BM_<Module name>_<Register name>_Bit name. 





More information about the linux-arm-kernel mailing list