[PATCHv2] ARM: perf/oprofile: fix off-by-one in stack check

Will Deacon will.deacon at arm.com
Wed Feb 9 05:10:42 EST 2011


Hi Rabin,

> Since tail is the previous fp - 1, we need to compare the new fp with tail + 1
> to ensure that we don't end up passing in the same tail again, in order to
> avoid a potential infinite loop in the perf interrupt handler (which has been
> observed to occur).  A similar fix seems to be needed in the OProfile code.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent at stericsson.com>
> ---
> v2: refined check as per Will's comment
> 
>  arch/arm/kernel/perf_event.c |    2 +-
>  arch/arm/oprofile/common.c   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Looks good, thanks.

Acked-by: Will Deacon <will.deacon at arm.com>

Will






More information about the linux-arm-kernel mailing list