[PATCH] ARM: Correct WFE() in asm/spinlock.h for Thumb-2

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Feb 8 11:40:09 EST 2011


On Tue, Feb 08, 2011 at 03:20:14PM +0000, Dave Martin wrote:
> The content for ALT_SMP() in the definition of WFE() expands to 6
> bytes (IT cc ; WFEcc.W), which breaks the assumptions of the fixup
> code, leading to lockups when the affected code gets run.

Why does it?  My understanding is that the .w suffix forces the assembler
to use the ARM encoding for the instruction.

Thumb2 is just far too weird to understand.  I think I'll just stick to
writing good ARM code and let people sort out the Thumb2 weirdnesses.



More information about the linux-arm-kernel mailing list