[PATCH v2 4/9] omap: clocks: Add checks to see if enable/disable ops are supported

Paul Walmsley paul at pwsan.com
Mon Feb 7 20:48:26 EST 2011


On Fri, 4 Feb 2011, Santosh Shilimkar wrote:

> From: Rajendra Nayak <rnayak at ti.com>
> 
> Check if enable/disable operations are supported for a given
> clock node before attempting to call them.
> 
> Signed-off-by: Rajendra Nayak <rnayak at ti.com>
> ---
>  arch/arm/mach-omap2/clock.c |   14 +++++++++-----
>  1 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
> index 2a2f152..5c08c18 100644
> --- a/arch/arm/mach-omap2/clock.c
> +++ b/arch/arm/mach-omap2/clock.c
> @@ -261,7 +261,8 @@ void omap2_clk_disable(struct clk *clk)
>  
>  	pr_debug("clock: %s: disabling in hardware\n", clk->name);
>  
> -	clk->ops->disable(clk);
> +	if (clk->ops && clk->ops->enable)
> +		clk->ops->disable(clk);

Shouldn't that read:

    if (clk->ops && clk->ops->disable)

?


- Paul



More information about the linux-arm-kernel mailing list