[PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs voltage files

Menon, Nishanth nm at ti.com
Mon Feb 7 00:33:15 EST 2011


On Sat, Feb 5, 2011 at 04:24, Kevin Hilman <khilman at ti.com> wrote:
> Vasiliy Kulikov <segoon at openwall.com> writes:
>
>> Don't allow everybody to change voltage settings.
>>
>> Signed-off-by: Vasiliy Kulikov <segoon at openwall.com>
>> ---
>>  Cannot compile the driver, so it is not tested at all.
>
> Acked-by: Kevin Hilman <khilman at ti.com>
Also fixes the checkpatch warning:
scripts/checkpatch.pl -f arch/arm/mach-omap2/smartreflex.c
WARNING: Exporting world writable files is usually an error. Consider
more restrictive permissions.
#903: FILE: arm/mach-omap2/smartreflex.c:903:
+	(void) debugfs_create_file("autocomp", S_IRUGO | S_IWUGO, dbg_dir,

total: 0 errors, 1 warnings, 1028 lines checked

Acked-by: Nishanth Menon <nm at ti.com>

Regards,
Nishanth Menon



More information about the linux-arm-kernel mailing list