[PATCH 1/5] dmaengine: mxs-dma: add dma support for i.MX23/28

[Russell King - ARM Linux]

Shawn,

A couple more points below.

On Sat, Feb 05, 2011 at 10:08:12AM +0800, Shawn Guo wrote:
> +	mxs_dma->dev = &pdev->dev;
...
> +	mxs_dma->dma_device.dev = &pdev->dev;

Do you need mxs_dma->dev, or could you just use mxs_dma->dma_device.dev
throughout?

> +static int __exit mxs_dma_remove(struct platform_device *pdev)
> +{
> +	return -EBUSY;
> +}

As the return code is ignored, it's probably better to omit the remove
function entirely.