[PATCH 1/5] ARM: etm: Don't require clock control
Arve Hjønnevåg
arve at android.com
Thu Feb 3 19:30:46 EST 2011
On Thu, Feb 3, 2011 at 4:45 AM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Feb 02, 2011 at 06:54:19PM -0800, Arve Hj??nnev??g wrote:
>> If clk_get fail, assume the etb does not need a separate clock.
>>
>> Signed-off-by: Arve Hj??nnev??g <arve at android.com>
>
> Would it not be cleaner for the affected platforms to ensure that
> clk_get() does the right thing here, for example by returning a dummy
> clock? Otherwise we'll just silently carry on if we can't get a clock
> we were supposed to which doesn't seem ideal.
>
This clock seem to be an omap specific virtual clock that switches the
clock source of the etb. It is not used to enable the clock when the
etb is in use, and it does not seem to have a failure case other than
not existing. So, I don't know that requiring this clock would cause
fewer problems than making it optional.
--
Arve Hjønnevåg
More information about the linux-arm-kernel
mailing list