[PATCH 2/4] davinci: add spi devices support for MityDSP-L138/MityARM-1808 platform
Michael Williamson
michael.williamson at criticallink.com
Tue Feb 1 07:33:08 EST 2011
Hi Sekhar,
On 2/1/2011 7:21 AM, Nori, Sekhar wrote:
> Hi Mike,
>
> On Tue, Feb 01, 2011 at 05:35:14, Michael Williamson wrote:
>> This patch adds support for accessing the on board SPI NOR FLASH
>> device for MityDSP-L138 and MityARM-1808 SoMs.
>>
>> Signed-off-by: Michael Williamson <michael.williamson at criticallink.com>
>> Tested-by: Michael Williamson <michael.williamson at criticallink.com>
>> ---
>> arch/arm/mach-davinci/board-mityomapl138.c | 104 ++++++++++++++++++++++++++++
>> 1 files changed, 104 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c
>
>
>> +
>> +static struct davinci_spi_platform_data mityomapl138_spi1_pdata = {
>> + .version = SPI_VERSION_2,
>> + .num_chipselect = 1,
>> + .intr_line = 1,
>> +};
>
> This platform data is better placed in devices-da8xx.c as most of
> it is common across all DA8xx platforms. Only num_chipselect and
> chip_sel array are expected to be board specific so only those should
> be passed on from board files.
>
> Thanks,
> Sekhar
I will move this to devices-da8xx.c and create a placeholder for spi0.
Thanks.
-Mike
More information about the linux-arm-kernel
mailing list