[RFC] cpufreq: Add S3C2416/S3C2450 cpufreq driver

Dron Gus dron0gus at gmail.com
Fri Dec 30 02:48:30 EST 2011


Hi.

On Thu, Dec 29, 2011 at 11:58 PM, Heiko Stübner <heiko at sntech.de> wrote:
...
> +static int __init s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy)
...
> +       s3c_freq->armdiv = clk_get(NULL, "armdiv");
> +       if (IS_ERR(s3c_freq->armdiv)) {
> +               pr_err("cpufreq: Unable to obtain ARMDIV: %ld\n",
> +                      PTR_ERR(s3c_freq->armdiv));
> +               return PTR_ERR(s3c_freq->armdiv);
> +       }
> +
> +       s3c_freq->hclk = clk_get(NULL, "hclk");
> +       if (IS_ERR(s3c_freq->hclk)) {
> +               pr_warn("cpufreq: Unable to obtain HCLK: %ld\n",
> +                      PTR_ERR(s3c_freq->hclk));
> +               s3c_freq->hclk = NULL; /*we can live without hclk */
> +       }
clk_put allready obtained "armdiv"?

> +
> +       s3c_freq->armclk = clk_get(NULL, "armclk");
> +       if (IS_ERR(s3c_freq->armclk)) {
> +               pr_err("cpufreq: Unable to obtain ARMCLK: %ld\n",
> +                      PTR_ERR(s3c_freq->armclk));
> +               return PTR_ERR(s3c_freq->armclk);
> +       }
Same for "hclk" and "armclk"?



More information about the linux-arm-kernel mailing list