[PATCH] MTD/GPMI bugfix : reset the BCH module when it is not MX23
Baruch Siach
baruch at tkos.co.il
Fri Dec 30 02:46:43 EST 2011
Hi Huang,
On Fri, Dec 30, 2011 at 11:28:10AM +0800, Huang Shijie wrote:
> In MX28, if we do not reset the BCH module. The BCH module may
> becomes unstable when the board reboots for several thousands times.
> This bug has been catched in customer's production.
>
> The patch adds some comments, and fixes it now.
>
> Also change gpmi_reset_block() to static.
>
> Signed-off-by: Huang Shijie <b32955 at freescale.com>
> ---
[snip]
> - ret = gpmi_reset_block(r->bch_regs, true);
> + /* The bug only exits in mx23, the following chips fix it. */
> + if (GPMI_IS_MX23(this))
> + ret = gpmi_reset_block(r->bch_regs, true);
> + else
> + ret = gpmi_reset_block(r->bch_regs, false);
This can be shortened to:
ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MX23(this));
> if (ret)
> goto err_out;
>
> --
> 1.7.0.4
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
More information about the linux-arm-kernel
mailing list