[PATCH 4/4] arm/imx: add mc13892 support into imx51-babbage.dts

[Richard Zhao]

On Wed, Dec 21, 2011 at 11:00:47PM +0800, Shawn Guo wrote:
> It adds mc13892 support into imx51-babbage device tree source.
> 
> Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> Cc: Sascha Hauer <s.hauer at pengutronix.de>
> ---
>  arch/arm/boot/dts/imx51-babbage.dts |   93 ++++++++++++++++++++++++++++++++++-
>  1 files changed, 91 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> index 564cb8c..728c9e8 100644
> --- a/arch/arm/boot/dts/imx51-babbage.dts
> +++ b/arch/arm/boot/dts/imx51-babbage.dts
> @@ -31,12 +31,14 @@
>  				esdhc at 70004000 { /* ESDHC1 */
>  					fsl,cd-internal;
>  					fsl,wp-internal;
> +					vmmc-supply = <&vsd_reg>;
>  					status = "okay";
>  				};
>  
>  				esdhc at 70008000 { /* ESDHC2 */
>  					cd-gpios = <&gpio1 6 0>;
>  					wp-gpios = <&gpio1 5 0>;
> +					vmmc-supply = <&vsd_reg>;
>  					status = "okay";
>  				};
>  
> @@ -56,8 +58,95 @@
>  						compatible = "fsl,mc13892";
>  						spi-max-frequency = <6000000>;
>  						reg = <0>;
> -						mc13xxx-irq-gpios = <&gpio1 8 0>;
> -						fsl,mc13xxx-uses-regulator;
> +						interrupt-parent = <&gpio1>;
> +						interrupts = <8>;
Why do we put everything in /soc node? Isn't it suppose to put
everything outside SoC outside /soc node?

In my understanding, i2c/spi node in /soc should only describe the bus
host controller. Especially i2c is a multi-master bus.

Thanks
Richard

> +
> +						regulators {
 
Thanks
Richard