[PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver
broonie at opensource.wolfsonmicro.com
Wed Dec 28 07:14:04 EST 2011
On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote:
Looks like the problem with your mail client is that it's wrapping at
exactly 80 characters which is too little - you need to leave space for
> On Wed, Dec 28, 2011 at 11:42:37AM +0000, Mark Brown wrote:
> > You can't usefully work with voltages without knowing what the actual
> > voltages are - the only sensible stubs we could provide would return
> > errors but then any driver using the stubs would probably fail to do
> > whatever it was doing. With enable and disable we can sensibly stub
> > things out with an always on regulator.
> Sorry, I can not get your point here. Let me describe the problem I met:
> - regulator_is_supported_voltage is not exported. when I build clk-reg-cpufreq
> as kernel module, there's a link error.
This is an oversight, I've just fixed it.
> - I saw linux/regulator/consumer.h has some dummy functions if !REGULATOR. I
> tried to make clk-reg-cpufreq driver work even !REGULATOR. I think that's
> why the dummy functions are there. If regulator_get return NULL, it'll avoid
> calling other regulator functions. But regulator_is_supported_voltage and
> regulator_set_voltage_time don't have such dummy ones. Undefined functions.
I can only repeat what I wrote above explaining why no stubs are
More information about the linux-arm-kernel