[PATCH v4] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

[Barry Song]

2011/12/21 Shawn Guo <shawn.guo at freescale.com>:
> On Wed, Dec 21, 2011 at 11:34:45AM +0800, Richard Zhao wrote:
>> On Wed, Dec 21, 2011 at 11:29:29AM +0800, Barry Song wrote:
>> > 2011/12/21 Russell King - ARM Linux <linux at arm.linux.org.uk>:
>> > > On Wed, Dec 14, 2011 at 04:55:27PM +0800, Barry Song wrote:
>> > >> +static int __devinit i2c_sirfsoc_probe(struct platform_device *pdev)
>> > >> +{
>> > >> +     struct clk *clk;
>> > >> +
>> > >> +     clk = clk_get(&pdev->dev, NULL);
>> > >> +     err = clk_prepare(clk);
>> > >> +     err = clk_enable(clk);
>> > > ...
>> > >> +     clk_disable(clk);
>> > >> +
>> > >> +     dev_info(&pdev->dev, " I2C adapter ready to operate\n");
>> > >> +
>> > >> +     return 0;
>> > >> +}
>> > >> +
>> > >> +static int __devexit i2c_sirfsoc_remove(struct platform_device *pdev)
>> > >> +{
>> > >> +     clk_disable(siic->clk);
>> > >> +     clk_unprepare(siic->clk);
>> > >> +     clk_put(siic->clk);
>> > >
>> There's a handy clk_disable_unprepare function in the patch I ever sent
>> out. It's in Sascha or Shawn's tree.
>>
> We cannot really ask people to use that before it hits Linus' tree.

Thanks. Shawn/Richard.
The problem is that Ben seems to have been scheduled to TASK_UNINTERRUPTIBLE.

>
> --
> Regards,
> Shawn
>

-barry