[RFC PATCH] ARM: new architecture for Energy Micro's EFM32 Cortex-M3 SoCs
jamie at jamieiles.com
Wed Dec 21 15:09:33 EST 2011
On Wed, Dec 21, 2011 at 07:56:02PM +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 21, 2011 at 03:48:50PM +0000, Jamie Iles wrote:
> > > +#define __io(a) __typesafe_io(a)
> > Do you support io ports on this platform? If not then perhaps select
> > NO_IPORT and define __io(a) to 0?
> Do not do that. Define NO_IOPORT and *do* *not* define __io() at all to
> make drivers which use PCI IO stuff fail at build time. Don't try to
> frig it into doing a NULL pointer deref.
Fair point. I said that because I remember that the 8250 driver uses
ioport accessors even for !HAVE_IOPORT and that some patches to remove
that were nacked, but I don't remember the details. But yes, not
defining __io would be much better!
More information about the linux-arm-kernel