[PATCH] pxa/hx4700: Fix PXA_GPIO_IRQ_BASE/IRQ_NUM values
mad_soft at inbox.ru
Wed Dec 21 14:19:02 EST 2011
On 15:12 Wed 21 Dec , Philipp Zabel wrote:
> Hello Paul,
> On Mon, Dec 12, 2011 at 11:21 PM, Paul Parsons <lost.distance at yahoo.com> wrote:
> > linux-2.6.32 changed the values of PXA_GPIO_IRQ_BASE and PXA_GPIO_IRQ_NUM from
> > 64/128 to 96/192. This has broken the hx4700 platform, for example its PCMCIA/CF
> > driver. The 9 EGPIO GPIOs have become numbered 256..264, and consequently fail
> > the gpio_is_valid() test in gpiolib.c (which limits GPIOs to the range 0..255).
> > This patch reverts the values of PXA_GPIO_IRQ_BASE and PXA_GPIO_IRQ_NUM to their
> > previous linux-2.6.31 values for the hx4700 platform only.
> > Signed-off-by: Paul Parsons <lost.distance at yahoo.com>
> > ---
> > +#ifdef CONFIG_MACH_H4700
> > +#define PXA_GPIO_IRQ_BASE PXA_IRQ(64)
> > +#define PXA_GPIO_IRQ_NUM (128)
> > +#else
> > #define PXA_GPIO_IRQ_BASE PXA_IRQ(96)
> > #define PXA_GPIO_IRQ_NUM (192)
> > +#endif
> machine specific definitions were removed from mach/irqs.h in commits
> 0dc726bb264ca5ecfdfab94a6937e0e9b9b26f64 ([ARM] pxa: move board board
> IRQ definitions out of irqs.h) and
> 6ac6b817f3f4c23c5febd960d8deb343e13af5f3 (ARM: pxa: encode IRQ number
> into .nr_irqs).
> I'd propose to increase ARCH_NR_GPIOs to 264 in mach/gpio.h or
> plat/gpio.h instead.
Yes, I also think increasing ARCH_NR_GPIO is the way to go.
BTW, there's a patchset floating around which moves such custom
settings of ARCH_NR_GPIO from mach/gpio.h into Kconfig variable:
I'm not sure though if it's going to be merged into 3.3
Dmitry "MAD" Artamonow
More information about the linux-arm-kernel