[PATCH] arm/tegra: boards: more __init/__initdata annotations

Olof Johansson olof at lixom.net
Tue Dec 20 12:06:41 EST 2011


On Tue, Dec 20, 2011 at 12:26 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Mon, Dec 19, 2011 at 08:03:22PM -0800, Olof Johansson wrote:
>> Silence a bunch of section warnings, and mark some of the init functions as
>> __init.
>>
>> Signed-off-by: Olof Johansson <olof at lixom.net>
>> ---
>>  arch/arm/mach-tegra/board-harmony-pinmux.c   |    8 ++++----
>>  arch/arm/mach-tegra/board-paz00-pinmux.c     |    8 ++++----
>>  arch/arm/mach-tegra/board-seaboard-pinmux.c  |   16 ++++++++--------
>>  arch/arm/mach-tegra/board-trimslice-pinmux.c |    4 ++--
>>  4 files changed, 18 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm/mach-tegra/board-harmony-pinmux.c b/arch/arm/mach-tegra/board-harmony-pinmux.c
>> index 465808c..84cfbef 100644
>> --- a/arch/arm/mach-tegra/board-harmony-pinmux.c
>> +++ b/arch/arm/mach-tegra/board-harmony-pinmux.c
>> @@ -25,7 +25,7 @@
>>  #include "board-harmony.h"
>>  #include "board-pinmux.h"
>>
>> -static struct tegra_pingroup_config harmony_pinmux[] = {
>> +static __initdata struct tegra_pingroup_config harmony_pinmux[] = {
>
> __initdata goes at the end of the declaration - just before the '='.

Thanks for pointing it out -- looks like a couple of other instances
use the wrong location as well (probably added by me in the past).
I'll respin the patch, and fix up those cases as well.

-Olof



More information about the linux-arm-kernel mailing list