buggy usage of pm_idle by omap1 code

Nicolas Pitre nico at fluxnic.net
Mon Dec 19 12:44:14 EST 2011

On Mon, 19 Dec 2011, Tony Lindgren wrote:

> * Nicolas Pitre <nico at fluxnic.net> [111216 18:53]:
> > 
> > I just noticed in mach-omap1/cpu.c:omap_pm_prepare() that the function 
> > pointer pm_idle is explicitly set to NULL for some vague reason.  
> > However this pointer is unconditionally dereferenced in 
> > kernel/process.c:cpu_idle().  This is just a oops waiting to happen.  
> > And if it doesn't happen in practice, then the code in omap_pm_prepare() 
> > must be useless in addition to being wrong.
> Good catch. Here's a patch to deal with that issue, want to take this
> into your idle series?


> I'll try out your idle series today at some
> point.



More information about the linux-arm-kernel mailing list