[PATCH v3] ARM: mxs: Add initial support for Bluegiga APX4 Development Kit
Russell King - ARM Linux
linux at arm.linux.org.uk
Mon Dec 19 04:13:22 EST 2011
On Mon, Dec 19, 2011 at 05:19:17PM +0800, Shawn Guo wrote:
> On Mon, Dec 19, 2011 at 09:13:16AM +0200, Lauri Hintsala wrote:
> > On 12/19/2011 09:13 AM, Shawn Guo wrote:
> > >The patch looks good.
> >
> > Thank you for your time.
> >
> >
> > >The only problem I have is I do not see MACH_TYPE_APX4DEVKIT defined
> > >in arch/arm/tools/mach-types on either Linus' tree or linux-next
> > >tree. I'm afraid that we will experience the same problem we have
> > >experienced with m28evk patch, which broke the whole mxs build for a
> > >couple of early -rc of v3.2.
> >
> > I see the problem. What is your suggestion? Should we create patch
> > to add APX4DEVKIT to mach-types file as you did last time?
> > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/140425
> >
> > We have register apx4devkit to ARM machine database. Machine id of
> > apx4devkit is 3712. For some reason "Kconfig macro" and "type
> > identifier" are out of sync in db. DEVKIT string is missing from
> > those.
> > http://www.arm.linux.org.uk/developer/machines/list.php?id=3712
> >
> Hi Russell,
>
> We have seen APX4DEVKIT in the ARM machine database. But you did not
> include it in the commit aef1c03 (ARM: Update mach-types) which is
> sitting on -next. Can you please include it as we plan to merge the
> board support during the coming merge window?
No. It will be automatically removed from any update as long as it does
not conform to the requirements - that is, in this case, the strings
being out of sync indentified in the message to which you replied to.
Someone needs to tell me what the correct entry is supposed to look like.
More information about the linux-arm-kernel
mailing list