[RFC PATCH] ARM: Fix the bug in dcache flush all API.
Will Deacon
will.deacon at arm.com
Fri Dec 16 06:40:43 EST 2011
On Fri, Dec 16, 2011 at 11:26:40AM +0000, Will Deacon wrote:
> So on a second look, I'm failing to see the problem you're describing. The
> thing that I reckon needs changing is this:
>
>
> diff --git a/arch/arm/mm/cache-v7.S b/arch/arm/mm/cache-v7.S
> index 07c4bc8..5ca3503 100644
> --- a/arch/arm/mm/cache-v7.S
> +++ b/arch/arm/mm/cache-v7.S
> @@ -58,7 +58,7 @@ loop1:
> isb @ isb to sych the new cssr&csidr
> mrc p15, 1, r1, c0, c0, 0 @ read the new csidr
> and r2, r1, #7 @ extract the length of the cache lines
> - add r2, r2, #4 @ add 4 (line length offset)
> + add r2, r2, #2 @ add 2 (line length offset)
> ldr r4, =0x3ff
> ands r4, r4, r1, lsr #3 @ find maximum number on the way size
> clz r5, r4 @ find bit position of way size increment
Actually, this is alright as well. We have to do a conversion from words to
bytes so we just add 2 to the power.
Maybe the only thing that needs changing is the comments :)
Will
More information about the linux-arm-kernel
mailing list