[PATCH v4 1/4] OMAP3: hwmod data: add mmu data for iva and isp

Felipe Contreras felipe.contreras at gmail.com
Thu Dec 15 19:39:16 EST 2011


On Thu, Dec 15, 2011 at 6:18 AM, Omar Ramirez Luna <omar.ramirez at ti.com> wrote:
> +/* l4_core -> isp mmu */
> +static struct omap_hwmod_ocp_if omap3xxx_l4_core__isp_mmu = {
> +       .master         = &omap3xxx_l4_core_hwmod,
> +       .slave          = &omap3xxx_isp_mmu_hwmod,
> +       .addr           = omap3xxx_isp_mmu_addrs,
> +       .user           = OCP_USER_MPU | OCP_USER_SDMA,
> +};

Are you sure you are not missing something like:

  .clk = "cam_ick",

> +/* isp mmu slave ports */
> +static struct omap_hwmod_ocp_if *omap3xxx_isp_mmu_slaves[] = {
> +       &omap3xxx_l4_core__isp_mmu,
> +};
> +
> +static struct omap_hwmod omap3xxx_isp_mmu_hwmod = {
> +       .name           = "isp_mmu",
> +       .class          = &omap3xxx_mmu_hwmod_class,
> +       .mpu_irqs       = omap3xxx_isp_mmu_irqs,
> +       .main_clk       = "cam_ick",

It's not "cam_fck"?

> +       .dev_attr       = &isp_mmu_dev_attr,
> +       .slaves         = omap3xxx_isp_mmu_slaves,
> +       .slaves_cnt     = ARRAY_SIZE(omap3xxx_isp_mmu_slaves),
> +       .flags          = HWMOD_NO_IDLEST,
> +};

Most of the stuff I see the hwmods is .main_lock = "foo_fck", slave
.clk = "foo_ick". Maybe that explains the irq issues you get.

Cheers.

-- 
Felipe Contreras



More information about the linux-arm-kernel mailing list