[PATCH v5 07/11] davinci: dm644x: Replace register base value with a defined macro

Hadli, Manjunath manjunath.hadli at ti.com
Thu Dec 15 06:11:58 EST 2011


Sergei,
On Wed, Dec 14, 2011 at 16:06:41, Sergei Shtylyov wrote:
> Hello.
> 
> On 13-12-2011 15:23, Manjunath Hadli wrote:
> 
> > Replace hard coded value of vpss register base to a define macro 
> > DM644X_VPSS_REG_BASE for proper readability
> 
> > Signed-off-by: Manjunath Hadli<manjunath.hadli at ti.com>
> > Acked-by: Sekhar Nori<nsekhar at ti.com>
> > ---
> >   arch/arm/mach-davinci/dm644x.c |    8 +++++---
> >   1 files changed, 5 insertions(+), 3 deletions(-)
> 
> > diff --git a/arch/arm/mach-davinci/dm644x.c 
> > b/arch/arm/mach-davinci/dm644x.c index 6b1d473..3802b59 100644
> > --- a/arch/arm/mach-davinci/dm644x.c
> > +++ b/arch/arm/mach-davinci/dm644x.c
> > @@ -594,13 +594,15 @@ static struct platform_device dm644x_asp_device = {
> >   	.resource	= dm644x_asp_resources,
> >   };
> >
> > +#define DM644X_VPSS_REG_BASE	0x01c73400
> > +
> 
>     Why not simply DM644X_VPSS_BASE, like all the other #define's?
There are #defines with _REG also like DAVINCI_DM646X_MCASP0_REG_BASE. But in the spirit of keeping it same for this file, I will change it.

> 
> WBR, Sergei
> 

Thx,
-Manju



More information about the linux-arm-kernel mailing list