[PATCH 3/4] ARM: smp_twd: get the rate from a clock

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Dec 13 03:17:23 EST 2011


On Tue, Dec 13, 2011 at 10:54:14AM +0530, Santosh Shilimkar wrote:
> > +static struct clk *twd_get_clock(void)
> > +{
> > +	struct clk *clk;
> > +	int err;
> > +
> > +	clk = clk_get_sys("smp_twd", NULL);
> 
> As noticed by Mike, would be better to use con_id instead
> of dev_id here. I mean,
> clk = clk_get_sys(NULL, "smp_twd");

Why?  It makes more sense for a device ID to be passed for this.



More information about the linux-arm-kernel mailing list