[PATCH] ARM: provide XIP_VIRT_ADDR for no-MMU builds

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Dec 10 05:11:22 EST 2011

On Sat, Dec 10, 2011 at 10:52:53AM +0100, Uwe Kleine-König wrote:
> On Sat, Dec 10, 2011 at 01:02:21AM +0000, Russell King - ARM Linux wrote:
> > On Fri, Dec 09, 2011 at 10:50:51PM +0100, Uwe Kleine-König wrote:
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > 
> > Lack of changelog.  Say why this change is required.
> Something like:
> 	XIP_VIRT_ADDR is needed for XIP builds and currently only
> 	defined for builds with CONFIG_MMU.
> 	Also provide it for no-MMU builds to make it possible to build
> 	an XIP kernel for MMU-less machines. As these lack an MMU it has
> 	to be an identity mapping.

You seem to be saying from the above that this is required also for
non-XIP kernel builds as well as XIP kernel builds.  That sounds wrong -
XIP_VIRT_ADDR is only required for XIP kernel builds.  Use outside of
that would be a bug.

Please clarify.

(And this illustrates why it is very important to give an explanation
of changes.)

More information about the linux-arm-kernel mailing list