[PATCH 2/2] regulator: add device tree support for max8997

Thomas Abraham thomas.abraham at linaro.org
Fri Dec 9 00:17:03 EST 2011

Dear Mr. Park,

On 9 December 2011 08:00, Kyungmin Park <kyungmin.park at samsung.com> wrote:
> On 12/9/11, Thomas Abraham <thomas.abraham at linaro.org> wrote:
>> Add device tree based discovery support for max8997.
>> Cc: MyungJoo Ham <myungjoo.ham at samsung.com>
>> Cc: Rajendra Nayak <rnayak at ti.com>
>> Cc: Rob Herring <rob.herring at calxeda.com>
>> Cc: Grant Likely <grant.likely at secretlab.ca>
>> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>


>> +#else
>> +static int *max8997_i2c_parse_dt_pdata(struct device *dev
>> +                                     struct max8997_platform_data **pdata)
> It should be 'int' instead of 'int *'
> It's helpful to compile without CONFIG_OF.

I apologize for that. I compiled for exynos-dt first and then compiled
for origen board (which does not select CONFIG_OF). When compiling for
non-dt origen, I missed to notice that CONFIG_OF selection was left
over from the previous exynos-dt compile.

I have checked again without CONFIG_OF and found this issue as well as
two other errors/warnings.

Thanks. This was very helpful.



More information about the linux-arm-kernel mailing list