[PATCH 3/3] ARM: S3C64XX: Implement basic power domain support

Rafael J. Wysocki rjw at sisk.pl
Wed Dec 7 16:44:02 EST 2011


On Friday, December 02, 2011, Mark Brown wrote:
> On Fri, Dec 02, 2011 at 09:10:27PM +0100, Sylwester Nawrocki wrote:
> 
> > > +	/* Not all domains provide power status readback */
> > > +	if (pd->pwr_stat) {
> > > +		while (retry--)
> > > +			if (__raw_readl(S3C64XX_BLK_PWR_STAT) & pd->pwr_stat)
> > > +				break;
> 
> > How about adding cpu_relax() in this busy wait loop ?
> 
> May as well, yes - I didn't actually measure how long it tends to take
> to do the spin but it's not going to hurt.

Are you going to post an updated patch?

Rafael



More information about the linux-arm-kernel mailing list