[PATCH V2 0/6] SPI platform device consolidation

[Kukjin Kim]

Padmavathi Venna wrote:
> 
> SPI platform devices are defined in respective machine folder of
> Samsung S3C64XX and S5P series SoCs.This patchset moves S3C64XX
> and S5P series of SPI platform devices to a common place plat-samsung.
> This patchset also creates SPI setup files for GPIO configurations and
> platform data initialization.
> 
> V2 Changes:
> Platform data initialized in a centralized setup file as suggested-by
> Mark Brown
> SPI Controller number is added in SPI controller defining structure.
> 
> Padmavathi Venna (6):
>   ARM: SAMSUNG: Consolidation of SPI platform devices to plat-samsung
>   ARM: S3C64XX: Modified files for SPI consolidation work
>   ARM: S5PC100: Modified files for SPI consolidation work.
>   ARM: S5P64X0: Modified files for SPI consolidation work
>   ARM: S5PV210: Modified files for SPI consolidation work
> 
> The following patch make the corresponding SPI changes required for
> Wolfson Cragganmore S3C6410 variant. This patch is only build tested.
> 
>   ARM: S3C64XX: Modified according to SPI consolidation work.
> 
>  arch/arm/mach-s3c64xx/Kconfig                    |    8 +-
>  arch/arm/mach-s3c64xx/Makefile                   |    2 +-
>  arch/arm/mach-s3c64xx/dev-spi.c                  |  172 -----------------
>  arch/arm/mach-s3c64xx/include/mach/map.h         |    2 +
>  arch/arm/mach-s3c64xx/setup-spi.c                |   47 +++++
>  arch/arm/mach-s5p64x0/Kconfig                    |    7 +-
>  arch/arm/mach-s5p64x0/Makefile                   |    2 +-
>  arch/arm/mach-s5p64x0/dev-spi.c                  |  218
---------------------
>  arch/arm/mach-s5p64x0/include/mach/map.h         |    3 +
>  arch/arm/mach-s5p64x0/setup-spi.c                |   57 ++++++
>  arch/arm/mach-s5pc100/Kconfig                    |    5 +
>  arch/arm/mach-s5pc100/Makefile                   |    2 +-
>  arch/arm/mach-s5pc100/dev-spi.c                  |  220
----------------------
>  arch/arm/mach-s5pc100/include/mach/map.h         |    3 +
>  arch/arm/mach-s5pc100/setup-spi.c                |   68 +++++++
>  arch/arm/mach-s5pv210/Kconfig                    |    5 +
>  arch/arm/mach-s5pv210/Makefile                   |    2 +-
>  arch/arm/mach-s5pv210/dev-spi.c                  |  169 -----------------
>  arch/arm/mach-s5pv210/include/mach/map.h         |    2 +
>  arch/arm/mach-s5pv210/setup-spi.c                |   53 +++++
>  arch/arm/plat-samsung/Kconfig                    |   14 ++-
>  arch/arm/plat-samsung/devs.c                     |  106 +++++++++++
>  arch/arm/plat-samsung/include/plat/devs.h        |    8 +-
>  arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |   20 ++-
>  24 files changed, 395 insertions(+), 800 deletions(-)
>  delete mode 100644 arch/arm/mach-s3c64xx/dev-spi.c
>  create mode 100644 arch/arm/mach-s3c64xx/setup-spi.c
>  delete mode 100644 arch/arm/mach-s5p64x0/dev-spi.c
>  create mode 100644 arch/arm/mach-s5p64x0/setup-spi.c
>  delete mode 100644 arch/arm/mach-s5pc100/dev-spi.c
>  create mode 100644 arch/arm/mach-s5pc100/setup-spi.c
>  delete mode 100644 arch/arm/mach-s5pv210/dev-spi.c
>  create mode 100644 arch/arm/mach-s5pv210/setup-spi.c

Hi Padma,

Sorry for late response.

Basically, looks good to me, but need to re-submit because of following.

You need to just move 'resource's and 'platform_device's from each dev-spi.c
file into plat-samsung/devs.c in your 1st patch then move 'gpio setup' to
each setup-spi.c files in other patches.

I think, above ensures bisect of your patches :)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.