[RFC PATCH v1 2/7] omap4: build fdif omap device from hwmod
ming.lei at canonical.com
Sun Dec 4 23:25:24 EST 2011
On Fri, Dec 2, 2011 at 8:10 PM, Sergei Shtylyov <sshtylyov at ru.mvista.com> wrote:
> On 02-12-2011 13:12, Ming Lei wrote:
>> Signed-off-by: Ming Lei<ming.lei at canonical.com>
>> arch/arm/mach-omap2/devices.c | 33 +++++++++++++++++++++++++++++++++
>> 1 files changed, 33 insertions(+), 0 deletions(-)
>> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
>> index 1166bdc..a392af5 100644
>> --- a/arch/arm/mach-omap2/devices.c
>> +++ b/arch/arm/mach-omap2/devices.c
>> @@ -728,6 +728,38 @@ void __init omap242x_init_mmc(struct
>> omap_mmc_platform_data **mmc_data)
>> +static struct platform_device* __init omap4_init_fdif(void)
> Shouldn't there be space before *? checkpatch.pl is silent about it?
> ALso, I'd have placed '__init' after 'static'...
Yes, you are right, will do do it in next version.
>> + int id = -1;
>> + struct platform_device *pd;
>> + struct omap_hwmod *oh;
>> + const char *dev_name = "fdif";
> Why you need this variable at all?
Will remove some of them.
More information about the linux-arm-kernel