[PATCH 3/4] ARM Exynos4210-Nuri: remove compiler errors

Kukjin Kim kgene.kim at samsung.com
Sat Dec 3 04:26:14 EST 2011


MyungJoo Ham wrote:
> 
> On Fri, Dec 2, 2011 at 5:59 PM, Kukjin Kim <kgene.kim at samsung.com> wrote:
> > MyungJoo Hamm wrote:
> >>
> > What's the 'compiler errors'?
> >
> > And I don't know why this patch included in this series, maybe this
> should
> > be separated from this series?
> 
> The error is:
> arch/arm/mach-exynos/mach-nuri.c: In function 'nuri_power_init':
> arch/arm/mach-exynos/mach-nuri.c:1080:2: error: implicit declaration
> of function 'irq_alloc_descs'

Well, I couldn't find the 'irq_alloc_descs' at the
arch/arm/mach-exynos/mach-nuri.c file in my tree and linux-next. Maybe you
missed submitting some patches?

And I don't know why inclusion of <linux/export.h> is needed for
'irq_alloc_descs'...

> It is due to the recent changes in some of the header files (they
> removed some header inclusion from header fiiles).
> 
I think, if this is required, this fix should be separated because the build
error what you said will be happened without this series...

> In this patchset, we are providing a test case (Exynos4210-Nuri) for
> the device driver and we had to resolve the compiler error first.
> 
If so, yes, firstly that should be fixed...but now don't we need this?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list