backlight/ld9040.c: regulator control in the lcd driver

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Dec 2 05:31:40 EST 2011


On Fri, Dec 02, 2011 at 05:57:35PM +0900, Kyungmin Park wrote:

> As mentioned at commit message, the lcd regulator is optional part and
> refer the mmc codes

>         host->vmmc = regulator_get(mmc_dev(mmc), "vmmc");
>         if (IS_ERR(host->vmmc)) {
>                 pr_info("%s: no vmmc regulator found\n", mmc_hostname(mmc));
>                 host->vmmc = NULL;
>         } else {
>                 regulator_enable(host->vmmc);
>         }

> Previous time, these codes are located at board file, but more boards
> are used, it has same codes for all boards. so move it to drivers.

In the case of MMC the MMC guys told us that this supply was entirely
optional for MMC operation, it wasn't an essential supply for the MMC
device to run it just enabled more features.  For supplies like that
it's OK for the regulator to fail, the driver should just not do
whatever things are enabled by having that supply.



More information about the linux-arm-kernel mailing list