backlight/ld9040.c: regulator control in the lcd driver

Linus Walleij linus.walleij at linaro.org
Fri Dec 2 03:49:16 EST 2011


On Fri, Dec 2, 2011 at 8:45 AM, leedonghwa <dh09.lee at samsung.com> wrote:

[From your mail headers]
> X-Mailer: Microsoft Office Outlook 12.0

No please. That mailer does not work, all your whitespace is screwed up.
Consult: Documentation/email-clients.txt

> This patch supports regulator power control in the driver.

Always CC the regulator maintainers on patches like this please.

> +         lcd->reg_vdd3 = regulator_get(lcd->dev, "vdd");
> +         if (IS_ERR(lcd->reg_vdd3)) {
> +                   dev_info(lcd->dev, "no %s regulator found\n", "vdd");
> +                   lcd->reg_vdd3 = NULL;
> +         }
> +
> +         lcd->reg_vci = regulator_get(lcd->dev, "vci");
> +         if (IS_ERR(lcd->reg_vci)) {
> +                   dev_info(lcd->dev, "no %s regulator found\n", "vci");
> +                   lcd->reg_vci = NULL;
> +         }

As explained in earlier discussion with Mark regarding the SMSC911x
driver regulator, treat these as errors and do not fail
"gracefully" like this.

Reference:
http://marc.info/?l=linux-netdev&m=131914562120725&w=2

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list