[PATCH 1/1] mmc: sdhci-esdhc: Change delay after setting clock from 100ms to 1ms

[Huang Changming-R66093]

I don't think it make sense to change the delay time.
Which will affect all PowerPC eSDHC controller, could you confirm which can work on all PowerPC platform?

-----Original Message-----
From: linux-mmc-owner at vger.kernel.org [mailto:linux-mmc-owner at vger.kernel.org] On Behalf Of Lin Tony-B19295
Sent: Friday, December 02, 2011 1:37 PM
To: Chris Ball
Cc: linux-mmc at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Xie Xiaobo-R63061; avorontsov at ru.mvista.com
Subject: RE: [PATCH 1/1] mmc: sdhci-esdhc: Change delay after setting clock from 100ms to 1ms

Okay
Thanks

> -----Original Message-----
> From: linux-mmc-owner at vger.kernel.org [mailto:linux-mmc- 
> owner at vger.kernel.org] On Behalf Of Chris Ball
> Sent: Friday, December 02, 2011 2:11 AM
> To: Lin Tony-B19295
> Cc: linux-mmc at vger.kernel.org; linux-arm-kernel at lists.infradead.org; 
> Xie Xiaobo-R63061; avorontsov at ru.mvista.com
> Subject: Re: [PATCH 1/1] mmc: sdhci-esdhc: Change delay after setting 
> clock from 100ms to 1ms
> 
> Hi,
> 
> On Tue, Nov 22 2011, Tony Lin wrote:
> > 1ms is enough for hardware to change the clock to stable.
> > 100ms is too long in the tasklet.
> >
> > Signed-off-by: Tony Lin <tony.lin at freescale.com>
> > CC: Xiaobo Xie <X.Xie at freescale.com>
> > CC: Anton Vorontsov <avorontsov at ru.mvista.com>
> > ---
> >  drivers/mmc/host/sdhci-esdhc.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-esdhc.h 
> > b/drivers/mmc/host/sdhci-esdhc.h index c3b08f1..b97b2f5 100644
> > --- a/drivers/mmc/host/sdhci-esdhc.h
> > +++ b/drivers/mmc/host/sdhci-esdhc.h
> > @@ -73,7 +73,7 @@ static inline void esdhc_set_clock(struct 
> > sdhci_host *host, unsigned int clock)
> >  		| (div << ESDHC_DIVIDER_SHIFT)
> >  		| (pre_div << ESDHC_PREDIV_SHIFT));
> >  	sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL);
> > -	mdelay(100);
> > +	mdelay(1);
> >  out:
> >  	host->clock = clock;
> >  }
> 
> I don't know if 1ms is actually long enough for the clock to stabilize 
> on all boards, but I'll push this change to mmc-next and we can see if 
> we get any regression reports.
> 
> Thanks,
> 
> - Chris.
> --
> Chris Ball   <cjb at laptop.org>   <http://printf.net/>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" 
> in the body of a message to majordomo at vger.kernel.org More majordomo 
> info at http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo at vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html