[PATCH] mmc: mmci: Fixup error handling for dma

Linus Walleij linus.walleij at linaro.org
Thu Dec 1 08:01:46 EST 2011


On Wed, Nov 30, 2011 at 11:21 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:

>>       if (!cmd->data || cmd->error) {
>> -             if (host->data)
>> +             if (host->data) {
>> +                     /* Terminate the DMA transfer */
>> +                     if (dma_inprogress(host))
>> +                             mmci_dma_data_error(host);
>
> Doesn't this leave the DMA buffers mapped?

Yep it needs an mmci_dma_unmap() call too AFAICT,
Ulf will you update?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list