[PATCH v2 1/4] ARM: CSR: add rtc i/o bridge interface for SiRFprimaII

[Barry Song]

2011/8/24 Arnd Bergmann <arnd at arndb.de>:
> On Tuesday 23 August 2011, Arnd Bergmann wrote:
>> > +
>> > +void __iomem *sirfsoc_rtciobrg_base;
>> > +static DEFINE_SPINLOCK(rtciobrg_lock);
>>
>> sirfsoc_rtciobrg_base should be static as well. No other code can
>> properly access it anyway since the lock is static, too.
>
> Ah, I understand now how it's used from assembly code, but it took me a while
> to figure out why it's done that way and that I couldn't come up with a better
> solution either. Please add a comment above sirfsoc_rtciobrg_base and
> sirfsoc_pwrc_base explaining that they are used from the suspend code and
> that you don't need locking there.

ok.
missed this one in my last reply.

>
>        Arnd
>

-barry