[PATCH v3] amba: consolidate PrimeCell magic

[Russell King - ARM Linux]

On Thu, Aug 18, 2011 at 11:08:07AM +0100, Tixy wrote:
> On Wed, 2011-08-17 at 19:49 +0100, Russell King - ARM Linux wrote:
> > On Wed, Aug 17, 2011 at 12:03:57PM -0500, H Hartley Sweeten wrote:
> > > > +	cellid = amba_get_pid((void __iomem *)((u32)base & PAGE_MASK), SZ_4K);
> > > 
> > > This produces a sparse warning.  But, the same warning was present with the
> > > old code.
> > > 
> > > arch/arm/common/vic.c:353:49: warning: cast removes address space of expression
> > 
> > That's prabably because casting from a pointer to a u32 (unsigned int)
> > isn't the best thing to do.  Casting to unsigned long is much better,
> > and iirc doesn't provoke such a sparse warning.
> 
> Is there any reason not to use uintptr_t for things like this?

Probably not - it's just history that we've tended to use the base C
types rather than the typedef'd stuff for this kind of thing.