[PATCH v3] amba: consolidate PrimeCell magic
Tixy
tixy at yxit.co.uk
Thu Aug 18 06:08:07 EDT 2011
On Wed, 2011-08-17 at 19:49 +0100, Russell King - ARM Linux wrote:
> On Wed, Aug 17, 2011 at 12:03:57PM -0500, H Hartley Sweeten wrote:
> > > + cellid = amba_get_pid((void __iomem *)((u32)base & PAGE_MASK), SZ_4K);
> >
> > This produces a sparse warning. But, the same warning was present with the
> > old code.
> >
> > arch/arm/common/vic.c:353:49: warning: cast removes address space of expression
>
> That's prabably because casting from a pointer to a u32 (unsigned int)
> isn't the best thing to do. Casting to unsigned long is much better,
> and iirc doesn't provoke such a sparse warning.
Is there any reason not to use uintptr_t for things like this?
More information about the linux-arm-kernel
mailing list