[PATCH 5/5] OMAP3: cpuidle: change the power domains modes determination logic

Jean Pihet jean.pihet at newoldbits.com
Fri Apr 29 10:00:40 EDT 2011

Hi Santosh,

On Fri, Apr 29, 2011 at 1:29 PM, Santosh Shilimkar
<santosh.shilimkar at ti.com> wrote:
> On 4/29/2011 2:56 PM, jean.pihet at newoldbits.com wrote:
>> From: Jean Pihet<j-pihet at ti.com>
>> The achievable power modes of the power domains in cpuidle
>> depends on the system wide 'enable_off_mode' knob in debugfs.
>> Upon changing enable_off_mode, do not change the C-states
>> 'valid' field but instead dynamically restrict the power modes
>> when entering idle.
>> The C-states 'valid' field is just used to enable/disable some
>> C-states at init and shall not be changed later on.
>> Signed-off-by: Jean Pihet<j-pihet at ti.com>

> Since you have started clean-up, we should get rid of the
> "enable_off_mode" some how. I got that done for OMAP4 using
> prepare() hook and IGNORE flag as per Kevin's suggestion
> but unfortunately its seems to getting removed from
> core cpuidle code.

The idea is to remove the enable_off_mode knob from debugfs and
instead have the devices constraints API control the power domains
Cf. PATCH 0/5 of this series for some remarks about further clean-up work.


> Regards
> Santosh

More information about the linux-arm-kernel mailing list