[PATCH 09/14] at91: switch pit timer to early platform devices

Tony Lindgren tony at atomide.com
Fri Apr 29 02:08:02 EDT 2011


* Russell King - ARM Linux <linux at arm.linux.org.uk> [110428 04:32]:
> On Thu, Apr 28, 2011 at 01:23:03PM +0200, Andrew Victor wrote:
> > hi,
> > 
> > > this will allow to specify the resources per soc
> > >
> > > as the 5series use a different start address for the pit
> > 
> > I really don't see the fascination with early platform_devices for timer.
> > A sys_timer is initialized way earlier, and there are surely cleaner
> > ways to just pass a "base address" through to the driver.
> > The interrupt is always AT91_ID_SYS on all chips, so there is no point
> > making it configurable.
> 
> Me too - it looks like this early device stuff is heading in the
> wrong direction.

Me too. Most of the stuff can be initialized much later and really
only timer and interrupts are needed early. Sure there are easily
dependencies to clock framework etc, but only those clocks need
to be initialized.

Regards,

Tony



More information about the linux-arm-kernel mailing list