[PATCH v2 02/23] at91: Make Ethernet device common

[Ryan Mallon]

On 04/28/2011 09:15 PM, Russell King - ARM Linux wrote:
> On Thu, Apr 21, 2011 at 06:19:37PM -0500, H Hartley Sweeten wrote:
>> +static struct platform_device at91_eth_device = {
>> +	.name		= "macb",
>> +	.id		= -1,
>> +	.dev		= {
>> +		.dma_mask		= &at91_eth_device.dev.coherent_dma_mask,
>> +		.coherent_dma_mask	= DMA_BIT_MASK(32),
>>
>> That will get rid of the static u64 variable used for every dma
>> capable device.
> 
> I've never really liked that, because coherent_dma_mask is never changed,
> but the value pointed to be dma_mask can be by drivers.  See dma_set_mask().
> 
> So, calling dma_set_mask() on any device which does the above will also
> (unexpectedly?) change the coherent mask too.
> 
> It's a minor point as we don't have many platform drivers using
> dma_set_mask().

I've got a couple of other minor changes, but will aim to push out an
updated version of the series today. Russell, are you happy for me to
leave the dma_mask stuff as is in the series?

Thanks,
~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934