AT91: Convert to fasteoi IRQ handler, and remove ARM irq_finish

Sebastian Andrzej Siewior sebastian at breakpoint.cc
Thu Apr 28 15:24:03 EDT 2011


* Andrew Victor | 2011-04-28 19:12:23 [+0200]:

>hi,
>
>>> -     desc->irq_data.chip->irq_unmask(&desc->irq_data);
>>> -     /* now it may re-trigger */
>>> +     /* acknowledge interrupt - now it may re-trigger */
>>> +     desc->irq_data.chip->irq_eoi(&desc->irq_data);
>>>  }
>>
>> why does this handler mess with the parent irq chip ?
>> this looks pretty wrong to me.
>
>This is a chained-handler, and without that line the end-of-interrupt
>doesn't seem to be signalled.

Most chain handler don't mess with other irq chips. Why is the parent
irq hanlder set level and not eoi? Wouldn't this make this superflous?

btw: tglx removed direct desc access so this patch won't apply.

>Regards,
>  Andrew Victor

Sebastian



More information about the linux-arm-kernel mailing list