[PATCH] at91: fix map_io init usage

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Apr 28 14:29:28 EDT 2011


On Thu, Apr 28, 2011 at 07:37:20PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> switch early init to init_early and introduce soc map_io
> 
> with this Patch we will not do any more early device setup during the map io
> 
> tks to Russel to point the new call back
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
> Cc: Patrice Vilchez <patrice.vilchez at atmel.com>
> Cc: Russell King <linux at arm.linux.org.uk>

Acked-by: Russell King <rmk+kernel at arm.linux.org.uk>

The only thing I'd suggest is:

> @@ -94,7 +94,8 @@ MACHINE_START(ONEARM, "Ajeco 1ARM single board computer")
>  	/* Maintainer: Lennert Buytenhek <buytenh at wantstofly.org> */
>  	.boot_params	= AT91_SDRAM_BASE + 0x100,
>  	.timer		= &at91rm9200_timer,
> -	.map_io		= onearm_map_io,
> +	.map_io		= at91rm9200_map_io,
>  	.init_irq	= onearm_init_irq,
> +	.init_early	= onearm_init_early,
>  	.init_machine	= onearm_board_init,

Ordering these as:
	.map_io
	.init_early
	.init_irq

as that's the order which they're called.  The struct itself is actually
layed out such that the members are called in order (which is: fixup,
map_io, init_early, init_irq, timer, init_machine).  I wouldn't suggest
doing a needless change to .timer in this patch though.



More information about the linux-arm-kernel mailing list